Custom shader not working in runtime

🌵 Needle Engine
1

I made a toon shader via a custom shader node using a hlsl file but it does not work once I hit play. In the Unity scene the material does work tho.

So I wanted to know if custom toon shader is compatible with Needle, or ar least via custom shader. I am using unlit shader in URP.

Original Post on Discord

by user 392492156583018497

2

Hey, Unlit shaders can be converted, Lit shaders can’t. What’s not working in the web / how does it look?

3

In the Scene I can see the shader working but once I hit play it is not displaying in the web:

image.png
image.png1903×820 170 KB

by user 392492156583018497

4

I am using an Unlit shader in URP

by user 392492156583018497

5

the shader also uses a custom function node

image.png
image.png859×521 54.4 KB

by user 392492156583018497

6

it is a .hlsl code

by user 392492156583018497

7 
#define MAINLIGHT_INCLUDED


void GetMainLightData_float(out half3 direction, out half3 color)
{
#ifdef SHADERGRAPH_PREVIEW

    direction = half3(-0.3, -0.8, 0.6);
    color = half3(1, 1, 1);

#else

#if defined(UNIVERSAL_LIGHTING_INCLUDED)
    
        Light mainLight = GetMainLight();
        direction = mainLight.direction;
        color = mainLight.color;

    #endif


#endif
}

#endif```

*by user 392492156583018497*
8

do you think it is because of this code? thank you in advance!

by user 392492156583018497

9

Yes it is! So you’re using an Unlit node but you pull in basically the same code as a Lit node would use

10

Turning this into a Lit node effectively.

11

What you can do is get rid of that and just have direction (Vector3) and color (Vector3) inputs on the node, so “hardcode” them

12

Hi! do you mean like this:
image.png

by user 392492156583018497

13

Yes, that should work - if it gets rid of your custom node above that runs the light loop

14

Hello! I chaged it but still not working. Looks like in the first picture. I should point that I also got these warnings:

image.png
image.png1451×188 20.2 KB

by user 392492156583018497

15

I have a feeling something is not correctly installed in my setup lol

by user 392492156583018497

16

Hi can you try/check two things:

  • the shader has the ExportShader asset tag?
  • a) remove the property in the shader and just plug in a normal vector 3 for the light values?
  • b) invert x in the light direction vector, it might look wrong in unity but would be interesting to see how it looks on the web

If you can share screenshots like above for each test it would be great