Turning off the default OrbitControls?

🌵 Needle Engine
21

Ok yes - I hope we can get past the circular dependency issue soon :crossed_fingers:

22

Yah, the only reason I picked that template was because I couldn’t get the default to work. Let me see if I can’t figure that out.

by user 106501920008445952

23

I think that circular dependency issue started happening when we upgraded from vite 2.6.x to vite 3.x

24

but not sure

25

I’m wonder if y’all can get around that by pulling out Behaviour into it’s own file instead of having it nested in Component

by user 106501920008445952

26

Let me try that locally

by user 106501920008445952

27

Ok thank you :slightly_smiling_face:

28

I used GitHub - pahen/madge: Create graphs from your CommonJS, AMD or ES6 module dependencies to show the circular dependencies and there’s a bunch of them, so it might be tough to unravel to fix those bugs.

by user 106501920008445952

29

Yeah it’s tough unfortunately - what I dont understand is how it didnt cause any problems until few weeks ago.

30

since I don’t have access to the source, maybe you could do a git bisect to find the commit that introduced it?

by user 106501920008445952

31

The difficult part is that it doesnt always reproduce - at least for me it only happens once in a while

32

That’s so interesting. I’m pretty much the opposite. I can rarely ever get it to work lol

by user 106501920008445952

33

It seems to heavily depend on the project - having a project here were it happens very often: which is good I guess

34

and now I dont get it to break anymore :unamused:

35

Good news - we removed A TON of circular dependencies :sweat_smile: need to debug and test more but looks promising that we’ll fix this issue soon (and we will add some automatic testing to hopefully avoid re-introducing that again)

36

@0xFluffhead would be great if you could try the new release

37

Ok awesome, I’ll take it for a spin in the next hour

by user 106501920008445952

38

Found some more bugs already and there are still some circular dependencies in there - will release a fix soon - so not 100% done there just so you know :slightly_smiling_face:

39

All good, let’s just see if it gets past that other error :slightly_smiling_face: booting up now

by user 106501920008445952

40

What’s the proper way to upgrade? I upgraded the exporter package, then in my console did a clean npm install after removing node_modules and see this when running npm run start

by user 106501920008445952